[PATCH 1/1] filetype: add command support

[Sascha Hauer]

On Mon, Aug 13, 2012 at 10:03:03PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this will allow to detect the filetype of a file and export it as filetype
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  commands/Kconfig    |    5 +++++
>  commands/Makefile   |    1 +
>  commands/filetype.c |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 66 insertions(+)
>  create mode 100644 commands/filetype.c
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 92a8152..e9fb9f6 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -220,6 +220,11 @@ config CMD_DIRNAME
>  	  Strip last component of file name and store the result in a
>  	  environment variable
>  
> +config CMD_FILETYPE
> +	tristate
> +	depends on FILETYPE
> +	prompt "filetype"

How about a short description of the command here?

> +
> +static int do_filetype(int argc, char *argv[])
> +{
> +	int opt;
> +	enum filetype type;
> +	char* filename = NULL;
> +	int verbose = 0;
> +
> +	while ((opt = getopt(argc, argv, "vf:")) > 0) {
> +		switch (opt) {
> +		case 'f':
> +			filename = optarg;
> +			break;
> +		case 'v':
> +			verbose = 1;
> +			break;
> +		}
> +	}
> +
> +	if (!filename)
> +		return COMMAND_ERROR_USAGE;
> +
> +	type = file_name_detect_type(filename);
> +
> +	if (verbose)
> +		pr_info("%s: %s detected\n", filename,
> +			file_type_to_string(type));
> +
> +	export_env_ull("filetype" , type);

Normally we do this by passing the variable name to the command, see
readline, basename or getopt. Lets do it the same way here.

Also, we should export strings instead of numbers. The numbers are not
documented anywhere and I think we should not expose them.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |