[RFC 1/2] MIPS: start.S: add "barebox" label at _start + 8

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Apr 30 07:51:30 EDT 2012


On 20:04 Sat 28 Apr     , Antony Pavlov wrote:
> On 28 April 2012 17:52, Antony Pavlov <antonynpavlov at gmail.com> wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> > ---
> >  arch/mips/boot/start.S |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
> > index b756d40..d8f4fd5 100644
> > --- a/arch/mips/boot/start.S
> > +++ b/arch/mips/boot/start.S
> > @@ -52,6 +52,14 @@ _pc: addiu   \rd, ra, \label - _pc           # label is assumed to be
> >        .align 4
> >
> >  EXPORT(_start)
> > +
> > +       b       __start
> > +        nop
> > +
> > +       .ascii  "barebox"
> 
> There is the problem with mips64 (thank to Jean-Christophe).
> We must set offset for "barebox" string more explicitly.
> 
> I will remake the patches.
I double check by building the malta as 64bit it work but it's true it will be
better to specified the offset explecitly

btw we need to discuss with the kernel ML to add a Magic too in the
vmlinux.bin and vmlinu.bin to be able to detect there type automatically

Best Regards,
J.



More information about the barebox mailing list