[PATCH] usb.c: warning on USB_MAXINTERFACES overflow

[Sascha Hauer]

On Mon, Sep 12, 2011 at 02:25:46PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>

Applied to master.

Sascha

> ---
>  drivers/usb/core/usb.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
> index b01a797..5dc8afe 100644
> --- a/drivers/usb/core/usb.c
> +++ b/drivers/usb/core/usb.c
> @@ -207,6 +207,16 @@ static int usb_parse_config(struct usb_device *dev, unsigned char *buffer, int c
>  			     &buffer[index])->bInterfaceNumber != curr_if_num) {
>  				/* this is a new interface, copy new desc */
>  				ifno = dev->config.no_of_if;
> +				/* if ifno > USB_MAXINTERFACES, then
> +				 * next memcpy() will corrupt dev->config
> +				 */
> +				if (ifno > USB_MAXINTERFACES) {
> +					printf("ifno = %d > "
> +						"USB_MAXINTERFACES = %d !\n",
> +						ifno,
> +						USB_MAXINTERFACES);
> +					break;
> +				}
>  				dev->config.no_of_if++;
>  				memcpy(&dev->config.if_desc[ifno],
>  					&buffer[index], buffer[index]);
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |