[PATCH 9/9] arm/mach-pxa: add mioa701 board

[Robert Jarzmik]

Sascha Hauer <s.hauer at pengutronix.de> writes:
> Are the defines in this file used by generic code? If not, please put
> them into a board specific include file (or remove them if they are
> unused)
I intended to use these values in lowlevel_init.S. Isn't that the right place ?

>> diff --git a/arch/arm/boards/mioa701/lowlevel_init.S b/arch/arm/boards/mioa701/lowlevel_init.S
>> +	.section ".text_bare_init","ax"
>> +.global board_init_lowlevel
>> +board_init_lowlevel:
>> +	mov	r10, lr
>> +	/*
>> +	 * This piece of code should ensure at least:
>> +	 *  - getting SDRAM out of self-refresh, and/or setup SDRAM timings
>> +	 *  - putting the GPIO logic into a usable state
>> +	bl	stabilize_reset
>> +	bl	setup_sdram
>> +	bl	setup_gpios
>
> I can't find these functions in the patch. Is this used?
It's ... within a comment because these functions are not written yet. This is
where the config.h values will be used, and the 3 functions should be coded in a
next step.

Cheers.

-- 
Robert