[PATCH 5/7] resource: introduce add_usb_ehci_device to register echi device

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:52 Fri 29 Jul     , Sascha Hauer wrote:
> On Fri, Jul 29, 2011 at 07:52:55AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > pass the hccr and hcor register base via resource
> > 
> > instroduce add_generic_usb_echi_device with hccr = base + 0x100 and
> > hcor = base + 0x140
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> 
> Overall this looks better than my i.MX specific patch for ehci. I'll
> drop mine.
> 
> > 
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 844dc1d..54856a3 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -900,20 +900,22 @@ static int ehci_probe(struct device_d *dev)
> >  	host = &ehci->host;
> >  	dev->priv = ehci;
> >  
> > -	if (pdata) {
> > +	/* default to EHCI_HAS_TT to not change behaviour of boards
> > +	 * with platform_data
> > +	 */
> 
> Maybe you can fix this comment on the way: It should be 'without
> platform_data'
ok

Best Regards,
J.