[PATCH] at91sam9m10g45ek: add board revision support

[Sascha Hauer]

On Sat, Jan 15, 2011 at 04:50:35PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> > > index e5bd45e..4d35ebe 100644
> > > --- a/arch/arm/mach-at91/Kconfig
> > > +++ b/arch/arm/mach-at91/Kconfig
> > > @@ -174,7 +174,8 @@ config MACH_AT91SAM9M10G45EK
> > >  	bool "Atmel AT91SAM9M10G45-EK Evaluation Kit"
> > >  	select HAVE_NAND_ATMEL_BUSWIDTH_16
> > >  	help
> > > -	  Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit.
> > > +	  Select this if you are using Atmel's AT91SAM9M10G45-EK Evaluation Kit
> > > +	  or AT91SAM9G45-EKES or AT91SAM9M10-EKES (for those 2 select the LG LCD)
> > >  	  <http://atmel.com/dyn/products/tools_card_v2.asp?tool_id=4735>
> > 
> > Isn't it better to let the user choose the exact board type here and
> > select the display type automatically depending on the choice?
> They are nearly the same board and the idea is to allow to specify the lcd as
> we can change it and it's the only difference between the 3 boards,

Ok, fine. Note I didn't want to suggest a complete new board support,
only the Kconfig option. The user likely knows better which board he has
than what exact display is connected to it.
Can you then add a help text to the display choice? Something like:

+choice
+       prompt "LCD type"
+       depends on MACH_AT91SAM9M10G45EK
+
+config LCD_TRULY_TFT1N4633E
+       bool "truly TFT1N4633E"
+	help
+	  Found on AT91SAM9M10G45-EK
+
+config LCD_LG_LB043WQ1
+       bool "LG philips LB043WQ1"
+	help
+	  Found on AT91SAM9G45-EKES and AT91SAM9M10-EKES
+
+endchoice

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |