[PATCH 3/4] omap_hsmmc: setup mmc voltage on twl6030

[Sascha Hauer]

On Thu, Dec 15, 2011 at 09:58:28AM +0100, Alexander Aring wrote:
> Support the setup of the mmc voltage, when booting OMAP4 with twl6030
> from nand.
> 
>  
> +config MCI_OMAP_TWL6030_FIX
> +	bool "OMAP HSMMC TWL6030 FIX"
> +	depends on I2C_TWLCORE && MCI_OMAP_HSMMC && ARCH_OMAP4
> +	help
> +	  Enable TWL6030 support for mci device. OMAP4 Bootloader doesn't setup
> +	  mmc voltage. So to setup mmc voltage you need to enable this.

We do not need a config switch for this.

Please instead of putting this into driver code just put all code in
this patch into some function in arch/arm/mach-omap/omap4_twl6030_mmc.c
which you then call from your board code. This may not be the cleanest
way to do it but moving it into the mmc driver is not a good solution
either.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |