[PATCH] add bool types support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Nov 2 06:15:10 EST 2009


On 09:03 Mon 02 Nov     , Robert Schwebel wrote:
> On Mon, Nov 02, 2009 at 08:50:46AM +0100, Alessandro Rubini wrote:
> > I'm sorry, I don't understand. I swear bool true and false should
> > never be part of a sane C program.
> >
> > It's misleading, as people tend to write "if (x == true)" which is
> > almost always wrong. I didn't expect such definitions to be in a new
> > sane project like V2.
> 
> Seconded - we should simply use the usual semantics from the kernel.
> 
> I assume Jean has copied the sniplet from linux - it is in types.h there
> as well. However, we should change the code to be sane.
yes it's correct

for this patch I just intend to have the kernel semantic

but I agree with you alessandro we need to clean the "true" stuff also

Best Regards,
J.




More information about the u-boot-v2 mailing list