[PATCH 01/10] i.MX Nand: Set correct datawidth/pagesize in CCM module

Sascha Hauer s.hauer at pengutronix.de
Tue Dec 8 03:42:10 EST 2009


Hi Eric,

On Fri, Dec 04, 2009 at 04:00:36PM +0100, Eric Bénard wrote:
> Dear Sascha,
>
> Sascha Hauer a écrit :
>> +void imx_nand_set_layout(int writesize, int datawidth)
>> +{
>> +	unsigned int fmcr;
>> +
>> +	fmcr = readl(FMCR);
>> +
> are you sure this works ?
> FMCR is (*((volatile u32 *)(x))) (0x10027814) and thus this leads to a  
> date abort.

oh yes, you're right. Your patches are all ok, but can you please resend
them? They have tabs replaced with whitespaces, broken linebreaks and
the second patch does not have a signed of.

Thanks
  Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the u-boot-v2 mailing list