[PATCH ath-next] wifi: ath12k: Fix scan initiation failure handling
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Wed May 14 06:47:40 PDT 2025
On 5/14/2025 4:48 AM, Vignesh C wrote:
>
>
> On 5/13/2025 3:25 AM, Jeff Johnson wrote:
>> On 5/11/2025 11:58 PM, Vignesh C wrote:
>>> During a code review, it is observed that in the scenario
>>> where scan initiation fails, the current code schedules the
>>> ar->scan.timeout workqueue which is not necessary.
>>
>> Are there any user-visible effects?
>>
>
> When MAC debug is enabled, the message 'mac scan started' is displayed, which is misleading in scan start failure scenario. Additionally, a scan timeout work-queue is scheduled to attempt aborting the scan, which is unnecessary in such cases.
Since there are no stability issues this is not a candidate for backporting
>
>>>
>>> In the scan initiation failure scenario, exit the code instead
>>> of scheduling the ar->scan.timeout workqueue.
>>>
>>> Compile tested only.
>>>
>>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>>
>> If there are no user-visible effects then I'll drop the Fixes tag since there
>> is no reason to backport this to stable kernel versions.
>>
>
> Kindly refer the above comment and please let me know the next steps.
There are no actions required on your part.
I've made the change in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=4545ccf7efbd97566eb6d98738013bb6d72ced05
More information about the ath12k
mailing list