[PATCH v4 1/3] wifi: ath12k: Dump PDEV transmit rate HTT stats

Aditya Kumar Singh aditya.kumar.singh at oss.qualcomm.com
Thu Jan 30 21:04:30 PST 2025


On 1/13/25 12:47, Lingbo Kong wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> index 4b59976fbc35..4a40b3b7bccb 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.h
> @@ -129,6 +129,7 @@ enum ath12k_dbg_htt_ext_stats_type {
>   	ATH12K_DBG_HTT_EXT_STATS_PDEV_ERROR		= 5,
>   	ATH12K_DBG_HTT_EXT_STATS_PDEV_TQM		= 6,
>   	ATH12K_DBG_HTT_EXT_STATS_TX_DE_INFO		= 8,
> +	ATH12K_DBG_HTT_EXT_STATS_PDEV_TX_RATE	= 9,
>   	ATH12K_DBG_HTT_EXT_STATS_TX_SELFGEN_INFO	= 12,
>   	ATH12K_DBG_HTT_EXT_STATS_SRNG_INFO		= 15,
>   	ATH12K_DBG_HTT_EXT_STATS_SFM_INFO		= 16,
> @@ -173,6 +174,7 @@ enum ath12k_dbg_htt_tlv_tag {
>   	HTT_STATS_TX_PDEV_MU_MIMO_STATS_TAG		= 25,
>   	HTT_STATS_SFM_CMN_TAG				= 26,
>   	HTT_STATS_SRING_STATS_TAG			= 27,
> +	HTT_STATS_TX_PDEV_RATE_STATS_TAG	= 34,
>   	HTT_STATS_TX_PDEV_SCHEDULER_TXQ_STATS_TAG	= 36,
>   	HTT_STATS_TX_SCHED_CMN_TAG			= 37,
>   	HTT_STATS_SCHED_TXQ_CMD_POSTED_TAG		= 39,

Your version log says you have aligned to match '='. But in above two 
additions, I see it is still not aligned. Is it just me?

Anyways, those are simple tab alignment, and if Jeff is okay to fix in 
pending then I'm fine.


Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh at oss.qualcomm.com>

-- 
Aditya




More information about the ath12k mailing list