[RFC PATCH 3/5] wifi: ath12k: add ath12k_hw_regs for IPQ5424
Jeff Johnson
jeff.johnson at oss.qualcomm.com
Thu Jan 30 11:03:21 PST 2025
On 1/30/2025 12:38 AM, Krzysztof Kozlowski wrote:
> On Thu, Jan 30, 2025 at 10:48:36AM +0530, Raj Kumar Bhagat wrote:
>> From: Saravanakumar Duraisamy <quic_saradura at quicinc.com>
>>
>> Add register addresses (ath12k_hw_regs) for new ath12k AHB based
>> WiFi device IPQ5424.
>>
>> Tested-on: IPQ5424 hw1.0 AHB WLAN.WBE.1.5-01053-QCAHKSWPL_SILICONZ-1
>> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Saravanakumar Duraisamy <quic_saradura at quicinc.com>
>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag at quicinc.com>
>> ---
>> drivers/net/wireless/ath/ath12k/hal.h | 3 +
>> drivers/net/wireless/ath/ath12k/hw.c | 87 ++++++++++++++++++++++++++-
>> 2 files changed, 89 insertions(+), 1 deletion(-)
>>
>
> That's not a separate patch. Regs do not make any sense on their own,
> so this commit makes no sense on its own.
This approach was suggested during internal review so that each addition can
be reviewed without distraction from the other pieces. None of this is
actually enabled until the final patch, so "trickling in" the pieces seems
preferable to me.
/jeff
More information about the ath12k
mailing list