[PATCH] wifi: ath12k: fbx: fix ath12k_hal_tx_cmd_ext_desc_setup() info1 override

[Karthikeyan Periyasamy]

On 1/26/2025 1:51 AM, Nicolas Escande wrote:
> On Sat Jan 25, 2025 at 3:54 PM CET, Vasanthakumar Thiagarajan wrote:
>>
>>
>> On 1/25/2025 6:23 PM, Nicolas Escande wrote:
>>> On Fri Jan 24, 2025 at 4:31 PM CET, Karthikeyan Periyasamy wrote:
>>>> On 1/24/2025 5:03 PM, Nicolas Escande wrote:
>>>>> Since inception there is an obvious typo laying around in
>>>>> ath12k_hal_tx_cmd_ext_desc_setup(). Instead of intitializing + adding
>>>>> flags to tcl_ext_cmd->info1, we initialize + override. This is needed to
>>>>> make broadcast frames work with ethernet encapsulation.
>>>>>
>>>>
>>>> SUPPORTS_TX_ENCAP_OFFLOAD not yet advertised by ath12k. How it work with
>>>> ethernet encapsulation ?
>>>
>>> Yes indeed, I made a small patch that adds the right hw features via a module
>>> param like one of your CLO patches did:
>>>
>>> +       if (ath12k_frame_mode == ATH12K_HW_TXRX_ETHERNET) {
>>> +               ieee80211_hw_set(hw, SUPPORTS_TX_ENCAP_OFFLOAD);
>>> +               ieee80211_hw_set(hw, SUPPORTS_RX_DECAP_OFFLOAD);
>>> +       }
>>> +
>>>
>>> But maybe as this feature is not yet enabled upstream I need remove the fixes
>>> tag ? After all It seems that in native wifi this bug causes no harm...
>>>
>>
>> That's right, also you may want to remove fbx prefix in the patch title
>> as this change has nothing to do with any particular platform/hardware.
> Yep indeed that fbx thing is an oversight on my part. I'll send an updated v2.
> 
> So You guys prefer I remove the fixes tag then ?
> 

Sure also you need to mention "ethernet encapsulation enabled in future"

-- 
Karthikeyan Periyasamy
--
கார்த்திகேயன் பெரியசாமி