[PATCHv2] wifi: ath12k: Avoid napi_sync before napi_enable

Aditya Kumar Singh aditya.kumar.singh at oss.qualcomm.com
Fri Jan 24 20:55:22 PST 2025


On 1/24/25 14:30, Tamizh Chelvam Raja wrote:
> From: Avula Sri Charan <quic_asrichar at quicinc.com>
> 
> In case of MHI error a reset work will be queued
> which will try napi_disable after napi_synchronize.

nit: always better to refer function name with () at end. I guess Jeff 
can fix in pending?

> 
> As the napi will be only enabled after qmi_firmware_ready
> event trying napi_synchronize before napi_enable will
> result in indefinite sleep in case of a firmware crash
> in QMI init sequence.
> 
> To avoid this introduce napi_enabled flag to check
> if napi is enabled or not before calling napi_synchronize.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Avula Sri Charan <quic_asrichar at quicinc.com>
> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr at quicinc.com>
> ---

Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh at oss.qualcomm.com>

-- 
Aditya



More information about the ath12k mailing list