[PATCH v9 6/9] wifi: ath12k: add support for setting fixed HE rate/GI/LTF

[Pradeep Kumar Chitrapu]

On 1/23/2025 3:06 AM, Maxime Bizon wrote:
> 
> On Mon, 2025-01-13 at 16:38 -0800, Pradeep Kumar Chitrapu wrote:
> 
> Hello,
>   
>> @@ -8376,10 +8637,13 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw,
>>   
>>          for (i = 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
>>                  arvif->bitrate_mask.control[i].legacy = 0xffffffff;
>> +               arvif->bitrate_mask.control[i].gi = NL80211_TXRATE_FORCE_SGI;
> 
> can you explain why it's not NL80211_TXRATE_DEFAULT_GI ?
> 
Hi Maxime

I believe, this is default GI based on device capability of HE for 
ath11k or EHT for ath12k.
>>                  memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
>>                         sizeof(arvif->bitrate_mask.control[i].ht_mcs));
>>                  memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
>>                         sizeof(arvif->bitrate_mask.control[i].vht_mcs));
>> +               memset(arvif->bitrate_mask.control[i].he_mcs, 0xff,
>> +                      sizeof(arvif->bitrate_mask.control[i].he_mcs));
>>          }
>>   
> 
> 
> The same initialization of he_mcs is missing in the ath12k_mac_assign_link_vif()
> 

Thanks for notifying..will fix it in next revision