[PATCH v2] wifi: ath12k: fix memory leak in ath12k_pci_remove()
Aditya Kumar Singh
aditya.kumar.singh at oss.qualcomm.com
Wed Jan 22 08:30:35 PST 2025
On 1/22/25 14:17, Miaoqing Pan wrote:
> --- a/drivers/net/wireless/ath/ath12k/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/pci.c
> @@ -1725,6 +1725,7 @@ static void ath12k_pci_remove(struct pci_dev *pdev)
> if (test_bit(ATH12K_FLAG_QMI_FAIL, &ab->dev_flags)) {
> ath12k_pci_power_down(ab, false);
> ath12k_qmi_deinit_service(ab);
> + ath12k_fw_unmap(ab);
> ath12k_core_hw_group_unassign(ab);
> goto qmi_fail;
> }
Instead of this, why not move the "qmi_fail:" label above unmap() ?
--
Aditya
More information about the ath12k
mailing list