[PATCH v3 4/6] wifi: ath12k: Add API to print s8 arrays in HTT stats

[Aditya Kumar Singh]

On 1/13/25 12:41, Roopni Devanathan wrote:
> Currently, print_array_to_buf() is used to print arrays to HTT
> stats buffer. This function supports printing only arrays with
> 32-bit unsigned integers. Add print_array_to_buf_s8(), which
> implements print_array_to_buf()'s functionality to all the
> arrays with 8-bit signed integers.
> 
> Sample output:
> rx_ul_mumimo_target_rssi: user_0  =  0:-128, 1:-128, 2:-128, 3:-128
> rx_ul_mumimo_target_rssi: user_1  =  0:-128, 1:-128, 2:-128, 3:-128
> rx_ul_mumimo_target_rssi: user_2  =  0:-128, 1:-128, 2:-128, 3:-128
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> 
> Signed-off-by: Roopni Devanathan <quic_rdevanat at quicinc.com>
> ---
>   .../wireless/ath/ath12k/debugfs_htt_stats.c   | 28 +++++++++++++++++++
>   1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index 77c51269669f..92935134735a 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -48,6 +48,34 @@ print_array_to_buf(u8 *buf, u32 offset, const char *header,
>   					footer);
>   }
>   
> +static u32
> +print_array_to_buf_s8(u8 *buf, u32 offset, const char *header, u32 stats_index,
> +		      const s8 *array, u32 array_len, const char *footer)


Who is the user of this new function? I don't see it called from
anywhere. At least have 1 caller to it in this patch?

Or else this patch fails to compile with W=1

drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c:52:1: error: 'print_array_to_buf_s8' defined but not used [-Werror=unused-function]
52 | print_array_to_buf_s8(u8 *buf, u32 offset, const char *header, u32 stats_index,
| ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

-- 
Aditya