[PATCH v5 0/4] wifi: ath12k: Factory test mode support

[Aaradhana Sahu]

On 1/9/2025 6:24 PM, Kalle Valo wrote:
> Jeff Johnson <jeff.johnson at oss.qualcomm.com> writes:
> 
>> On 1/8/2025 8:55 PM, Aditya Kumar Singh wrote:
>>
>>> On 1/9/25 10:13, Aaradhana Sahu wrote:
>>>>
>>>>
>>>> On 6/24/2024 3:23 PM, Aaradhana Sahu wrote:
>>>>> Device is booted in factory test mode for calibration.
>>>>> The commands are sent from userspace application, which
>>>>> is sent to firmware using wmi commands. Firmware sends
>>>>> the response to driver as wmi events and driver sends
>>>>> these events to the application via netlink message.
>>>>>
>>>>> Also added changes related to correct pdev id access for
>>>>> fw test cmd.
>>>>>
>>>>> Aaradhana Sahu (3):
>>>>>    wifi: ath: create common testmode_i.h file for ath drivers
>>>>>    wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
>>>>>    wifi: ath12k: add factory test mode support
>>>>>
>>>>> Rajat Soni (1):
>>>>>    wifi: ath12k: Fill pdev id for fw test cmd
>>>>>
>>>>> ---
>>>>> v5:
>>>>>    -Updated copyright
>>>>>    -Fixed line length within 90 char
>>>>> v4:
>>>>>    -Rebased on latest ToT
>>>>> v3:
>>>>>    -Rebased on latest ToT
>>>>>    -Updated Tested-on Tag
>>>>>    -Removed second parameter of ath12k_core_start()
>>>>>    -Updated copyright
>>>>> v2:
>>>>>    -Rebased on latest ath ToT
>>>>> ---
>>>>>
>>>>>   drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++--
>>>>>   drivers/net/wireless/ath/ath12k/Makefile      |   1 +
>>>>>   drivers/net/wireless/ath/ath12k/core.c        |  22 +-
>>>>>   drivers/net/wireless/ath/ath12k/core.h        |  13 +
>>>>>   drivers/net/wireless/ath/ath12k/debug.h       |   1 +
>>>>>   drivers/net/wireless/ath/ath12k/dp.c          |   3 +
>>>>>   drivers/net/wireless/ath/ath12k/mac.c         |  15 +-
>>>>>   drivers/net/wireless/ath/ath12k/pci.c         |   1 +
>>>>>   drivers/net/wireless/ath/ath12k/testmode.c    | 423 ++++++++++++++++++
>>>>>   drivers/net/wireless/ath/ath12k/testmode.h    |  40 ++
>>>>>   drivers/net/wireless/ath/ath12k/wmi.c         |  39 +-
>>>>>   drivers/net/wireless/ath/ath12k/wmi.h         |  21 +
>>>>>   .../wireless/ath/{ath11k => }/testmode_i.h    |  54 +--
>>>>>   13 files changed, 636 insertions(+), 75 deletions(-)
>>>>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c
>>>>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h
>>>>>   rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%)
>>>>>
>>>>>
>>>>> base-commit: cac9bfd02678adbcca9a7dce770609b9f7434d37
>>>>
>>>> Hi Kalle,
>>>>
>>>> Please let me know, if any thing is pending from the developer side, to merge this series into ath.git tree.
>>>
>>> This series does not apply cleanly on latest tip. And base commit is 
>>> around 6 months old. So may be you would want to rebase and send a new 
>>> version?
>>>
>>> Applying: wifi: ath: create common testmode_i.h file for ath drivers
>>> Applying: wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
>>> Applying: wifi: ath12k: add factory test mode support
>>> error: patch failed: drivers/net/wireless/ath/ath12k/Makefile:26
>>> error: drivers/net/wireless/ath/ath12k/Makefile: patch does not apply
>>> error: patch failed: drivers/net/wireless/ath/ath12k/core.c:42
>>> error: drivers/net/wireless/ath/ath12k/core.c: patch does not apply
>>> error: patch failed: drivers/net/wireless/ath/ath12k/core.h:209
>>> error: drivers/net/wireless/ath/ath12k/core.h: patch does not apply
>>> error: patch failed: drivers/net/wireless/ath/ath12k/debug.h:33
>>> error: drivers/net/wireless/ath/ath12k/debug.h: patch does not apply
>>> error: patch failed: drivers/net/wireless/ath/ath12k/mac.c:13
>>> error: drivers/net/wireless/ath/ath12k/mac.c: patch does not apply
>>> error: patch failed: drivers/net/wireless/ath/ath12k/wmi.c:7150
>>> error: drivers/net/wireless/ath/ath12k/wmi.c: patch does not apply
>>> Patch failed at 0003 wifi: ath12k: add factory test mode support
>>> hint: Use 'git am --show-current-patch=diff' to see the failed patch
>>> When you have resolved this problem, run "git am --continue".
>>> If you prefer to skip this patch, run "git am --skip" instead.
>>> To restore the original branch and stop patching, run "git am --abort".
>>>
>>> And since you'll be submitting in 2025, don't forget to update
>>> copyrights.
>>>
>>>
>>
>> Make sure to review all the changes that Kalle made locally to the pending
>> version and incorporate those.
> 
> BTW my changes are available in tag ath-pending-202407031443 and these
> are the commit ids:
> 
> 194fb8d58727 wifi: ath12k: Fill pdev id for fw test cmd
> 0ca2ecc31b40 wifi: ath12k: add factory test mode support
> df17f461e7c3 wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
> 593b976359bf wifi: ath: create common testmode_i.h file for ath drivers
> 
Thanks, I will pick your changes as well.