[PATCH 3/8] wifi: ath12k: Refactor sta state machine

Jeff Johnson quic_jjohnson at quicinc.com
Wed Oct 30 11:39:27 PDT 2024


On 10/30/2024 11:28 AM, Kalle Valo wrote:
> Aditya Kumar Singh <quic_adisi at quicinc.com> writes:
>> May be the comment in the code could be re-written as below?
>>
>> /* Driver must clear the keys during the state change from
>>  * IEEE80211_STA_AUTHORIZED to IEEE80211_STA_ASSOC, since after
>>  * returning from here, mac80211 is going to delete the keys
>>  * in __sta_info_destroy_part2(). This will ensure that the driver does
>>  * not retain stale key references after mac80211 deletes the keys.
>>  */
> 
> Looks good to me, I'll add that if it's ok for Jeff as well.
> 

Definitely ok, thanks for the clarification



More information about the ath12k mailing list