[PATCH v3 03/11] wifi: ath12k: fix struct hal_rx_ppdu_end_user_stats

Kalle Valo kvalo at kernel.org
Mon Oct 28 00:16:00 PDT 2024


Kang Yang <quic_kangyang at quicinc.com> writes:

> On 10/21/2024 4:50 PM, Kalle Valo wrote:
>> Kalle Valo <kvalo at kernel.org> writes:
>> 
>>> Kang Yang <quic_kangyang at quicinc.com> writes:
>>>
>>>> Current struct hal_rx_ppdu_end_user_stats in hal_rx.h is not matched
>>>> with hardware descriptor definition.
>>>>
>>>> So update this structure and related code.
>>>>
>>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>>
>>>> Signed-off-by: Kang Yang <quic_kangyang at quicinc.com>
>>>
>>> What about QCN9274? The commit message doesn't mention anything about
>>> that.
>> I have the same question for patches 3-6. Also I would like to
>> understand the backwards compatibility with older WCN7850 firmwares.
>
> For QCN9274, we reuse the same struct for them.
> WIN team already checked them during internal review.
>
> The struct definitions in patch 3-6 are hardware descriptor
> definition, won't be affected by firmware and host. They are fixed.

Please always include this information to the commit message so that we
know that you have done the research properly and the patch is not
breaking other hardware. ath12k is not only about WCN7850.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath12k mailing list