[PATCH v3] wifi: ath12k: convert tasklet to BH workqueue for CE interrupts

Kalle Valo kvalo at kernel.org
Thu Oct 24 02:48:25 PDT 2024


Jeff Johnson <quic_jjohnson at quicinc.com> writes:

> On 10/22/2024 12:24 AM, Raj Kumar Bhagat wrote:
>> Currently in Ath12k, tasklet is used to handle the BH context of CE
>> interrupts. However the tasklet is marked deprecated and has some
>> design flaws. To replace tasklets, BH workqueue support has been
>> added. BH workqueue behaves similarly to regular workqueues except
>> that the queued work items are executed in the BH context.
>> 
>> Hence, convert the tasklet to BH workqueue for handling CE interrupts
>> in the BH context.
>> 
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00214-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> (Not sure how to stress-test this, but it does survive multiple rmmod/insmod
> with a Youtube video stream running)

Raj, did you notice any changes in throughput?

Passes my tests as well:

Acked-by: Kalle Valo <kvalo at kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath12k mailing list