[PATCH v2] wifi: mac80211: re-order assigning channel in activate links

Aditya Kumar Singh quic_adisi at quicinc.com
Mon Oct 7 22:13:53 PDT 2024


On 10/1/24 15:49, Aditya Kumar Singh wrote:
> On 10/1/24 15:29, Johannes Berg wrote:
>> On Tue, 2024-10-01 at 14:20 +0530, Aditya Kumar Singh wrote:
...
>>
>> which sort of indicates that we're working around it, but it also
>> correctly says that we cannot activate a link before we have the (link)
>> station.
>>
>> In the flow as you changed it we'd activate the link in firmware before
>> the stations are added, but that isn't allowed. There's not really a
> 
> Is this a generic expectation? And that too only for ML STA? Since at 
> least for ML AP, we could have links in firmware active and later when 
> station connects, we create link stations.
> 
>> good place to hook into after the station is added, unless we somehow
>> want to activate the link from the station change, but that seems ...
>> odd to say the least? Though I guess it's already somewhat odd to init
>> rate control here as written now...
>>
>> Maybe we can hook into the later link info change. This seems to
>> initially work, but still doing more tests:
>>
> 
> sure, hoping that it passes all ;)
> 

Hi Johannes,

Is your testing complete? Do you see any issues with this change?

-- 
Aditya




More information about the ath12k mailing list