[PATCH] wifi: ath12k: Modify print_array_to_buf() to support arrays with 1-based semantics

Roopni Devanathan quic_rdevanat at quicinc.com
Fri Oct 4 01:57:02 PDT 2024



On 10/3/2024 8:26 PM, Jeff Johnson wrote:
> On 7/29/2024 8:51 PM, Roopni Devanathan wrote:
>> The API print_array_to_buf() currently supports printing
>> arrays with 0 indexing. In some cases, a few arrays need
>> to be printed with 1-based indexing, i.e., array should be
>> printed, starting with 1.
>>
>> Add a new version of print_array_to_buf(), named
>> print_array_to_buf_v2(), which implements the functionality
>> of print_array_to_buf(), but with an extra variable,
>> pointing to the index starting with which the array should
>> be printed. Modify print_array_to_buf() to call
>> print_array_to_buf_v2() with 0 as the starting index.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Roopni Devanathan <quic_rdevanat at quicinc.com>
> 
> I'm in the process of pulling in this change and the dependent debugfs
> patches, but was never quite happy with the naming of the new function.
> Discussed with Kalle and suggest the new function be called something like
> print_array_to_buf_index() so that the new name has some semantic guidance to
> how it is different.
> 
> Can you update this patch and the dependent ones to use this name?
> 
> /jeff
> 

Sure, Jeff. I'll make this change and send out the revised patches.



More information about the ath12k mailing list