[PATCH] wifi: ath12k: drop failed transmitted frames from metric calculation.

[Kalle Valo]

Karthikeyan Kathirvel <quic_kathirve at quicinc.com> writes:

> On 4/22/2024 1:35 PM, Nicolas Escande wrote:
>> On Fri Apr 19, 2024 at 7:03 PM CEST, Karthikeyan Kathirvel wrote:
>>
>>> +	case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_MPDU:
>>> +	case HAL_WBM_TQM_REL_REASON_DROP_THRESHOLD:
>>> +	case HAL_WBM_TQM_REL_REASON_CMD_REMOVE_AGED_FRAMES:
>>> +		/* The failure status is due to internal firmware tx failure
>>> +		 * hence drop the frame do not update the status of frame to
>>> +		 * the upper layer
>>> +		 */
>>> +		dev_kfree_skb_any(msdu);
>>
>> Shouldn't this be ieee80211_free_txskb ? I'm not clear when to use
>> which.
>
> Yes, there is an internal patch is in pipeline, that will take care of
> addressing all dev_kfree_skb_any() to ieee80211_free_txskb() in
> ath12k_dp_tx_complete_msdu(), this patch doesn't take care of that.

Let's not add new bugs knowingly. Please fix this patch to use
ieee80211_free_txskb(), that is much more reliable than waiting for some
other patch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches