[PATCH v3] wifi: ath12k: add support to handle beacon miss for WCN7850

Kalle Valo kvalo at kernel.org
Wed Apr 17 07:34:16 PDT 2024


"Nicolas Escande" <nico.escande at gmail.com> writes:

> On Fri Apr 12, 2024 at 11:44 AM CEST, kangyang wrote:
>
>> From: Kang Yang <quic_kangyang at quicinc.com>
>>
>> When AP goes down or too far away without indication to STA, beacon miss
>> will be detected. Then for WCN7850's firmware, it will use roam event
>> to send beacon miss to host.
>>
>> If STA doesn't handle the beacon miss, will keep the fake connection
>> and unable to roam.
>>
>> So add support for WCN7850 to trigger disconnection from AP when
>> receiving this event from firmware.
>>
>> It has to be noted that beacon miss event notification for QCN9274
>> to be handled in a separate patch as it uses STA kickout WMI event
>> to notify beacon miss and the current STA kickout event is processed
>> as low_ack.
>>
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>
>> Signed-off-by: Kang Yang <quic_kangyang at quicinc.com>

[...]

> LGTM, you can have my reviewed by if needed.

BTW patchwork adds Reviewed-by tags automatically to the patch, so all
good there, but _please_ edit your quotes. Including the full patch on
your reply makes use of patchwork really annoying, see here:

https://patchwork.kernel.org/project/linux-wireless/patch/20240412094447.2063-1-quic_kangyang@quicinc.com/

There was a trivial conflict in mac.h, I fixed it in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6dae20769f3f600a5ad5ee98b0fec0b14cf07a2f

I haven't seen any warnings yet, so that's good.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath12k mailing list