[PATCH 2/3] firmware: qcom: scm: pass qcom_scm through the exported API
Bryan O'Donoghue
bod at kernel.org
Wed Sep 23 14:08:19 PDT 2026
On 14/09/2026 13:41, Albert Esteve wrote:
> static int spm_cpuidle_drv_probe(struct platform_device *pdev)
> {
> + struct qcom_scm *scm = qcom_scm_get();
> int cpu, ret;
>
> - if (!qcom_scm_is_available())
> + if (!scm)
> return -EPROBE_DEFER;
Is this equivalent code ?
Its also a bit confusing to me that the next patch adds a .available
field to the qcom_scm struct.
I see where you do get drvdata but I haven't managed to find in the
series where the data gets set - haven't asked an LLM either - I think
the logic to associate the scm pointer and get it should live together
in one patch so that the logic is easier to find and reason about.
---
bod
More information about the ath10k
mailing list