[PATCH] wifi: ath10k: simplify SDIO async handling

Jeff Johnson quic_jjohnson at quicinc.com
Tue Sep 19 07:42:55 PDT 2023


On 9/18/2023 7:37 AM, Dmitry Antipov wrote:
> This is an initial attempt to fix TODO found in SDIO bus support
> code. As original comment says, an idea is to store SDIO-specific
> 'struct ath10k_sdio_bus_request' data within skb control buffer
> instead of managing (a relatively large, 1024-items for now) free
> list of the aforementioned structures.
> 
> Compile tested only so TESTERS WANTED.

While the maintainers like code to be as clean as possible, there is 
also the "if it isn't broke, don't fix it" mantra. This is especially 
true for older drivers that are in pure maintenance mode.

So unless you can show you are fixing a problem and you can actually 
test your patches (or recruit someone to do so), any patches to ath10k, 
especially to SDIO, won't be accepted.

Your team is doing some nice work, but I suggest you focus on drivers 
that are under active development, and preferably ones where you 
actually have the hardware to test.

/jeff



More information about the ath10k mailing list