[PATCH 1/3] wifi: ath10k: cleanup CE initialization
kernel test robot
lkp at intel.com
Wed Aug 23 00:34:47 PDT 2023
Hi Dmitry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on kvalo-ath/ath-next]
[also build test WARNING on wireless-next/main wireless/main linus/master v6.5-rc7 next-20230822]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Antipov/wifi-ath10k-simplify-ath10k_peer_assoc_h_vht/20230822-235854
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
patch link: https://lore.kernel.org/r/20230822155532.95983-1-dmantipov%40yandex.ru
patch subject: [PATCH 1/3] wifi: ath10k: cleanup CE initialization
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230823/202308231552.qVY1nOZs-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230823/202308231552.qVY1nOZs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308231552.qVY1nOZs-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath10k/snoc.c:1083:1: warning: unused label 'err_free_rri' [-Wunused-label]
err_free_rri:
^~~~~~~~~~~~~
1 warning generated.
vim +/err_free_rri +1083 drivers/net/wireless/ath/ath10k/snoc.c
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1056
3c545a25939c27 Rakesh Pillai 2019-02-08 1057 static int ath10k_snoc_hif_power_up(struct ath10k *ar,
3c545a25939c27 Rakesh Pillai 2019-02-08 1058 enum ath10k_firmware_mode fw_mode)
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1059 {
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1060 int ret;
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1061
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1062 ath10k_dbg(ar, ATH10K_DBG_SNOC, "%s:WCN3990 driver state = %d\n",
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1063 __func__, ar->state);
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1064
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1065 ret = ath10k_hw_power_on(ar);
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1066 if (ret) {
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1067 ath10k_err(ar, "failed to power on device: %d\n", ret);
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1068 return ret;
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1069 }
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1070
3c545a25939c27 Rakesh Pillai 2019-02-08 1071 ret = ath10k_snoc_wlan_enable(ar, fw_mode);
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1072 if (ret) {
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1073 ath10k_err(ar, "failed to enable wcn3990: %d\n", ret);
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1074 goto err_hw_power_off;
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1075 }
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1076
4945af5b264fbd Govind Singh 2018-04-17 1077 ath10k_ce_alloc_rri(ar);
4945af5b264fbd Govind Singh 2018-04-17 1078
7279d6262224cd Dmitry Antipov 2023-08-22 1079 ath10k_snoc_init_pipes(ar);
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1080
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1081 return 0;
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1082
31561e8557cd1e Rakesh Pillai 2020-12-12 @1083 err_free_rri:
31561e8557cd1e Rakesh Pillai 2020-12-12 1084 ath10k_ce_free_rri(ar);
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1085 ath10k_snoc_wlan_disable(ar);
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1086
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1087 err_hw_power_off:
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1088 ath10k_hw_power_off(ar);
5f1aa93ffa1f36 Rakesh Pillai 2020-12-12 1089
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1090 return ret;
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1091 }
0fa4fbe9b8cf76 Govind Singh 2018-04-10 1092
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the ath10k
mailing list