[PATCH] ath10k: Don't always treat modem stop events as crashes
Stephen Boyd
swboyd at chromium.org
Tue Sep 7 12:48:11 PDT 2021
Quoting Matthias Kaehlcke (2021-09-07 12:32:59)
> On Sun, Sep 05, 2021 at 02:04:00PM -0700, Stephen Boyd wrote:
> > @@ -1740,10 +1805,19 @@ static int ath10k_snoc_probe(struct platform_device *pdev)
> > goto err_fw_deinit;
> > }
> >
> > + ret = ath10k_modem_init(ar);
> > + if (ret) {
> > + ath10k_err(ar, "failed to initialize modem notifier: %d\n", ret);
>
> nit: ath10k_modem_init() encapsulates/hides the setup of the notifier,
> the error message should be inside the function, as for _deinit()
Sure. I can fix it. I was also wondering if I should drop the debug
prints for the cases that don't matter in the switch statement but I'll
just leave that alone unless someone complains about it.
More information about the ath10k
mailing list