[PATCH v2 2/5] treewide: Replace open-coded flex arrays in unions

[Marc Kleine-Budde]

On 25.08.2021 22:04:55, Kees Cook wrote:
> In support of enabling -Warray-bounds and -Wzero-length-bounds and
> correctly handling run-time memcpy() bounds checking, replace all
> open-coded flexible arrays (i.e. 0-element arrays) in unions with the
> flex_array() helper macro.
> 
> This fixes warnings such as:
> 
> fs/hpfs/anode.c: In function 'hpfs_add_sector_to_btree':
> fs/hpfs/anode.c:209:27: warning: array subscript 0 is outside the bounds of an interior zero-length array 'struct bplus_internal_node[0]' [-Wzero-length-bounds]
>   209 |    anode->btree.u.internal[0].down = cpu_to_le32(a);
>       |    ~~~~~~~~~~~~~~~~~~~~~~~^~~
> In file included from fs/hpfs/hpfs_fn.h:26,
>                  from fs/hpfs/anode.c:10:
> fs/hpfs/hpfs.h:412:32: note: while referencing 'internal'
>   412 |     struct bplus_internal_node internal[0]; /* (internal) 2-word entries giving
>       |                                ^~~~~~~~
> 
> drivers/net/can/usb/etas_es58x/es58x_fd.c: In function 'es58x_fd_tx_can_msg':
> drivers/net/can/usb/etas_es58x/es58x_fd.c:360:35: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'u8[0]' {aka 'unsigned char[]'} [-Wzero-length-bounds]
>   360 |  tx_can_msg = (typeof(tx_can_msg))&es58x_fd_urb_cmd->raw_msg[msg_len];
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/net/can/usb/etas_es58x/es58x_core.h:22,
>                  from drivers/net/can/usb/etas_es58x/es58x_fd.c:17:
> drivers/net/can/usb/etas_es58x/es58x_fd.h:231:6: note: while referencing 'raw_msg'
>   231 |   u8 raw_msg[0];
>       |      ^~~~~~~
> 
> Cc: "Gustavo A. R. Silva" <gustavoars at kernel.org>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Ayush Sawal <ayush.sawal at chelsio.com>
> Cc: Vinay Kumar Yadav <vinay.yadav at chelsio.com>
> Cc: Rohit Maheshwari <rohitm at chelsio.com>
> Cc: Herbert Xu <herbert at gondor.apana.org.au>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Kalle Valo <kvalo at codeaurora.org>
> Cc: Jakub Kicinski <kuba at kernel.org>
> Cc: Stanislaw Gruszka <stf_xl at wp.pl>
> Cc: Luca Coelho <luciano.coelho at intel.com>
> Cc: "James E.J. Bottomley" <jejb at linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen at oracle.com>
> Cc: Alexei Starovoitov <ast at kernel.org>
> Cc: Daniel Borkmann <daniel at iogearbox.net>
> Cc: Andrii Nakryiko <andrii at kernel.org>
> Cc: Martin KaFai Lau <kafai at fb.com>
> Cc: Song Liu <songliubraving at fb.com>
> Cc: Yonghong Song <yhs at fb.com>
> Cc: John Fastabend <john.fastabend at gmail.com>
> Cc: KP Singh <kpsingh at kernel.org>
> Cc: Johannes Berg <johannes.berg at intel.com>
> Cc: Mordechay Goodstein <mordechay.goodstein at intel.com>
> Cc: Lee Jones <lee.jones at linaro.org>
> Cc: Wolfgang Grandegger <wg at grandegger.com>
> Cc: Marc Kleine-Budde <mkl at pengutronix.de>
> Cc: Arunachalam Santhanam <arunachalam.santhanam at in.bosch.com>
> Cc: Vincent Mailhol <mailhol.vincent at wanadoo.fr>
> Cc: Mikulas Patocka <mikulas at artax.karlin.mff.cuni.cz>
> Cc: linux-crypto at vger.kernel.org
> Cc: ath10k at lists.infradead.org
> Cc: linux-wireless at vger.kernel.org
> Cc: netdev at vger.kernel.org
> Cc: linux-scsi at vger.kernel.org
> Cc: linux-can at vger.kernel.org
> Cc: bpf at vger.kernel.org
> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
>  drivers/net/can/usb/etas_es58x/es581_4.h          |  2 +-
>  drivers/net/can/usb/etas_es58x/es58x_fd.h         |  2 +-

For the can drivers:

Acked-by: Marc Kleine-Budde <mkl at pengutronix.de>

BTW: Is there opportunity for conversion, too?

| drivers/net/can/peak_canfd/peak_pciefd_main.c:146:32: warning: array of flexible structures

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath10k/attachments/20210826/a7b8c36f/attachment.sig>