[PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

Sebastian Gottschall s.gottschall at dd-wrt.com
Fri Mar 2 01:22:14 PST 2018


>> leds-gpio is crap and limited. you can just register one platform data at
>> kernel runtime since its identified by its object name "led-gpio" but the
>> kernel forbidds to register 2 platform datas with the same name
>> consider the ar71xx devices with qca988x wifi chipsets. they all have
>> already a led platform data registered
>> at boottime. a second can't be registered anymore so gpio_led is useless at
>> all for most developers on such platforms. its mainly used for early kernel
>> platform data initialisation for system leds.
> If leds-gpio has limitations, please fix those, rather then
> introducing duplicated code.
there is no duplicated code introduced and there is no solution for it. 
consider that all wifi drivers with softled support
are going that way with registering a own led driver. see ath9k for 
instance. gpio-led cannot be used for it and there is no way to
support multiple platform datas with the same name. its a kernel limitation

Sebastian
>
> NAK.
> 									Pavel


-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall at dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565




More information about the ath10k mailing list