9984 with 10.4.3.5.3-0057 crashes

Sebastian Gottschall s.gottschall at dd-wrt.com
Mon Apr 23 23:08:07 PDT 2018


Am 24.04.2018 um 07:27 schrieb Kalle Valo:
> Sebastian Gottschall <s.gottschall at dd-wrt.com> writes:
>
>> just for your notice. 10.4.3.5.3-0057 on 9984 which was just released
>> crashes in vht160 operation mode immediatly after first station
>> associates
>> last known working stable fw so far is 10.4-3.4-00104. the whole
>> 10.4.3.5.3 series seem to be seriously broken or the api has been
>> changed in a way
>> which is unsupported by ath10k (which i think is the cause of the 
>> problem)
>> it would be good to know what has been changed.
> At least I was not informed any changes in the firmware interface. What
> version of ath10k are you using? Do you have any custom patches on
> ath10k?
i'm using latest git version for testing here
but there is one relevant patch required for more recent firmwares like 
3.4 series (see below)
i posted already a long time ago, that vht160 will not work anymore 
without that patch in newer firmwares since
qca changed the api for channel mapping in vht160. (i took this 
information from the propertiery qca driver sourcecodes)
see our discussion on 2.feb 2017 about that required change. it seems 
that you lost the path on that issue.
as far as i know this change was required because of compatiblity issues 
with vht80 clients from some other vendors.
i have seen similar changes in hostapd for mwlwifi driver

--- wmi.c.old   2018-02-16 11:25:13.023117123 +0100
+++ wmi.c       2018-04-24 07:47:12.642395002 +0200
@@ -1661,13 +1661,18 @@ void ath10k_wmi_put_wmi_channel(struct w
                 flags |= WMI_CHAN_FLAG_HT40_PLUS;
         if (arg->chan_radar)
                 flags |= WMI_CHAN_FLAG_DFS;
-
+       ch->band_center_freq2 = 0;
         ch->mhz = __cpu_to_le32(arg->freq);
         ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1);
         if (arg->mode == MODE_11AC_VHT80_80)
                 ch->band_center_freq2 = 
__cpu_to_le32(arg->band_center_freq2);
-       else
-               ch->band_center_freq2 = 0;
+       if (arg->mode == MODE_11AC_VHT160)  {
+               if (arg->freq < arg->band_center_freq1)
+                       ch->band_center_freq1 = 
__cpu_to_le32(arg->band_center_freq1 - 40);
+               else
+                       ch->band_center_freq1 = 
__cpu_to_le32(arg->band_center_freq1 + 40);
+               ch->band_center_freq2 = 
__cpu_to_le32(arg->band_center_freq1);
+       }
         ch->min_power = arg->min_power;
         ch->max_power = arg->max_power;
         ch->reg_power = arg->max_reg_power;

>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall at dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565




More information about the ath10k mailing list