[PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block

[govinds at codeaurora.org]

On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh at kernel.org> writes:
> 
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>> 
>>> Signed-off-by: Govind Singh <govinds at codeaurora.org>
>>> ---
>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 31 
>>> ++++++++++++++++++++++
>>>  1 file changed, 31 insertions(+)
>> 
>> One nit, otherwise:
>> 
>> Reviewed-by: Rob Herring <robh at kernel.org>
>> 
> 
> [...]
> 
>>> @@ -119,3 +126,27 @@ wifi0: wifi at a000000 {
>>>  	qcom,msi_base = <0x40>;
>>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>>  };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi at 18000000 {
>> 
>> wifi at ...
> 
> I added this and Rob's Reviewed-by to the patch in the pending branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
> 
> Govind, please check that it's ok.

Looks good to me.

Thanks,
Govind