[PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

Kalle Valo kvalo at codeaurora.org
Fri Apr 6 01:07:39 PDT 2018


Sebastian Gottschall <s.gottschall at dd-wrt.com> writes:

> i have some comments about your check warnings.
> some of them are bogus. for instance they advise to use "unsigned int"
> instead of "unsigned". this might be better, but
> the original kernel header uses "unsigned" as api definition. so i
> decided to use the same declarations here.

Sure, but using "unsigned int" won't create any harm either.

> for the rest like whitespaces i will make a new version and remove them

You missed my comment in my earlier mail that I'll send the next
version. I have already fixed all the warnings so let me submit it. I'll
do also some other changes.

-- 
Kalle Valo



More information about the ath10k mailing list