[PATCH] ath10k : Fix channel survey dump

Adrian Chadd adrian at freebsd.org
Fri May 19 08:32:54 PDT 2017


On 19 May 2017 at 02:17, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Felix Fietkau <nbd at nbd.name> writes:
>
>> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>>> Channel active/busy time are showing incorrect
>>> (less than previous or sometimes zero) for
>>> successive survey dump command.

[snip]

>> Does the firmware read the registers directly, or does it accumulate
>> the results in a way that can't overflow? If you don't clear the
>> counters on reset, the overflow will be problematic for the
>> current-channel stats. I think a better approach would be to use
>> READ_CLEAR for in-use channels and store the sum inside the driver.
>
> Venkateswara, any comments?

I just bumped into this at work. I'm thinking of teaching mac80211
about optionally summing things so each driver doesn't need another
per-channel array.



-adrian



More information about the ath10k mailing list