[PATCH] ath10k: cache calibration data when the core is stopped.

Valo, Kalle kvalo at qca.qualcomm.com
Mon Oct 3 00:51:45 PDT 2016


Marty Faltesek <mfaltesek at google.com> writes:

> Caching calibration data allows it to be accessed when the
> device is not active.
>
> Signed-off-by: Marty Faltesek <mfaltesek at google.com>

[...]

> +int
> +ath10k_cal_data_alloc(struct ath10k *ar, void **buf)
> +{

[...]

> +	ath10k_cal_data_alloc(ar, &ar->cal_data);
[...]

> +	ret = ath10k_cal_data_alloc(ar, &file->private_data);

Pointer to pointer parameters can be a source of problems and if we
could use one shared buffer for both of these cases when it would
simplify the code and we would need the buf parameter at all.

-- 
Kalle Valo


More information about the ath10k mailing list