[RFC 09/12] ath10k: Mailbox address definitions

[Michal Kazior]

On 14 November 2016 at 17:33, Erik Stromdahl <erik.stromdahl at gmail.com> wrote:
> Address definitions for SDIO/mbox based chipsets.
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl at gmail.com>
> ---
>  drivers/net/wireless/ath/ath10k/hw.h |   53 ++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 883547f..46142e9 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -814,6 +814,59 @@ struct ath10k_hw_ops {
>  #define QCA9887_EEPROM_ADDR_LO_MASK            0x00ff0000
>  #define QCA9887_EEPROM_ADDR_LO_LSB             16
>
> +#define MBOX_RESET_CONTROL_ADDRESS             0x00000000
> +#define MBOX_HOST_INT_STATUS_ADDRESS           0x00000800
> +#define MBOX_HOST_INT_STATUS_ERROR_LSB         7
> +#define MBOX_HOST_INT_STATUS_ERROR_MASK                0x00000080

I would again suggest using Jakub's bitfield GET_FIELD stuff to get
rid of MASK+LSB and just have single define per register field. Kalle,
thoughts?


Michał