Crash related to c4cdf753 (move fw_features to struct ath10k_fw_file)

Ben Greear greearb at candelatech.com
Mon May 9 15:02:01 PDT 2016


I think that second chunk should use fw_file->fw.features instead of ar->running ... ???

It crashes everytime for me (wireless testing from a few days ago).

@@ -1074,13 +1074,13 @@ static int ath10k_core_fetch_firmware_api_n(struct ath10k *ar, const char *name,
                                         ath10k_dbg(ar, ATH10K_DBG_BOOT,
                                                    "Enabling feature bit: %i\n",
                                                    i);
-                                       __set_bit(i, ar->fw_features);
+                                       __set_bit(i, fw_file->fw_features);
                                 }
                         }

                         ath10k_dbg_dump(ar, ATH10K_DBG_BOOT, "features", "",
-                                       ar->fw_features,
-                                       sizeof(ar->fw_features));
+                                       ar->running_fw->fw_file.fw_features,
+                                       sizeof(fw_file->fw_features));
                         break;
                 case ATH10K_FW_IE_FW_IMAGE:
                         ath10k_dbg(ar, ATH10K_DBG_BOOT,


Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com




More information about the ath10k mailing list