[PATCH] ath10k: fix potential null dereference bugs

Valo, Kalle kvalo at qca.qualcomm.com
Tue Jun 14 07:39:52 PDT 2016

Bob Copeland <me at bobcopeland.com> writes:

>> > However, with all this, I think I'd simply not take any chances - the
>> > patch isn't exactly invasive and in some cases (for example the first
>> > hunk of the patch) will even improve the code to the point where the
>> > compiler could warn about uninitialized usage of the pointer when the
>> > code gets modified to use it in case of !txq->sta.
>> >
>> > I'd take it, but I guess it's Kalle's decision :)
>> Yeah, I'm leaning towards Johannes. These are not really invasive.
> Thanks, and sorry about the checkpatch -- I did run checkpatch on it but
> for some reason my version only complained about some of them.

I actually have a custom script which enables (and disables) various
checkpatch checks, most likely that's why you didn't see it.


Kalle Valo

More information about the ath10k mailing list