[PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode

Kalle Valo kvalo at qca.qualcomm.com
Mon Nov 16 12:57:44 PST 2015


"Li, Yanbo" <yanbol at qca.qualcomm.com> writes:

>> > +		/* The padding bytes's location is different on various chips */
>> > +		enum ath10k_loc_4addr_pad loc_4addr_pad;
>> 
>> I think that loc prefix is a bit misleading, it reminds me of
>> locationing/positioning etc. What about ath10k_hw_4addr_pad?
>> 
>
>
> There is already a FW feature defined as
> "ATH10K_FW_FEATURE_NO_NWIFI_DECAP_4ADDR_PADDIND" and the relative
> string is "no-4addr-pad", if we just remove the "loc" prefix, it may
> be confuse with this FW feature.
>
> How about we change the loc to offset in this case or any better suggestion?

I did some naming changes in the pending branch:

https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=42cd3832cd7c78bfeabb639a4086c7838fda5b57

Please review and let me know what you think.

-- 
Kalle Valo



More information about the ath10k mailing list