compiling decode_ath10k.cc with clang/llvm

[Ben Greear]

That is from my private tree, so list cannot help you...

Looks like real bugs...I'll make attempt at fixing it.

Thanks,
Ben


On 05/27/2015 11:43 PM, Adrian Chadd wrote:
> Hi,
>
> I'm doing firmware bringup on freebsd, and I've hit a snag with
> decode_ath10k.cc:
>
> Suspended
> adrian at lucy-11i386:~/git/dev.qualcomm.com/greaarb/ath10k-firmware % ./BUILDME.sh
> decode_ath10k.cc:1266:28: error: use of logical '&&' with constant
> operand [-Werror,-Wconstant-logical-operand]
>               (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
>                             ^  ~~~
> decode_ath10k.cc:1266:28: note: use '&' for a bitwise operation
>               (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
>                             ^~
>                             &
> decode_ath10k.cc:1266:28: note: remove constant to silence this warning
>               (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
>                            ~^~~~~~
> decode_ath10k.cc:1407:37: error: comparison of unsigned expression >=
> 0 is always true [-Werror,-Wtautological-compare]
>                          if ((sp_idx >= 0) && (sp_idx < len)) {
>                               ~~~~~~ ^  ~
> decode_ath10k.cc:2019:23: error: format specifies type 'unsigned
> short' but the argument has type 'unsigned char' [-Werror,-Wformat]
>        printf("%02hx", header.uuid[i]);
>                ~~~~~   ^~~~~~~~~~~~~~
>                %02hhx
>
> .. would someone who can use the firmware try fixing the source and
> see if it still does the right thing?
>
>
> -a
>
> _______________________________________________
> ath10k mailing list
> ath10k at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com