[PATCH v4 5/6] ath10k: add wmi support for tdls

[Arik Nemtsov]

On Mon, Mar 23, 2015 at 10:59 AM, Marek Puzyniak
<marek.puzyniak at tieto.com> wrote:
> On 23 March 2015 at 09:09, Michal Kazior <michal.kazior at tieto.com> wrote:
>> On 22 March 2015 at 08:49, Arik Nemtsov <arik at wizery.com> wrote:
>>> On Fri, Mar 20, 2015 at 1:02 PM, Marek Puzyniak
>>> <marek.puzyniak at tieto.com> wrote:
>>>> As a part of tdls implementation introduce
>>>> tdls related wmi data structures, constant
>>>> values and functions.
>>>>
>>>> Signed-off-by: Marek Puzyniak <marek.puzyniak at tieto.com>
>>>> ---
>>>>  drivers/net/wireless/ath/ath10k/wmi-ops.h |  42 ++++++++
>>>>  drivers/net/wireless/ath/ath10k/wmi-tlv.c | 153 ++++++++++++++++++++++++++++++
>>>>  drivers/net/wireless/ath/ath10k/wmi-tlv.h |  53 +++++++++++
>>>>  drivers/net/wireless/ath/ath10k/wmi.h     |  37 ++++++++
>>>>  4 files changed, 285 insertions(+)
>>> [...]
>>>> +
>>>> +       cmd = (void *)tlv->value;
>>>> +       cmd->vdev_id = __cpu_to_le32(vdev_id);
>>>> +       cmd->state = __cpu_to_le32(state);
>>>> +       cmd->notification_interval_ms = __cpu_to_le32(5000);
>>>> +       cmd->tx_discovery_threshold = __cpu_to_le32(100);
>>>> +       cmd->tx_teardown_threshold = __cpu_to_le32(5);
>>>> +       cmd->rssi_teardown_threshold = __cpu_to_le32(-75);
>>>> +       cmd->rssi_delta = __cpu_to_le32(-20);
>>>> +       cmd->tdls_options = __cpu_to_le32(options);
>>>> +       cmd->tdls_peer_traffic_ind_window = __cpu_to_le32(2);
>>>> +       cmd->tdls_peer_traffic_response_timeout_ms = __cpu_to_le32(5000);
>>>> +       cmd->tdls_puapsd_mask = __cpu_to_le32(0xf);
>>>> +       cmd->tdls_puapsd_inactivity_time_ms = __cpu_to_le32(0);
>>>> +       cmd->tdls_puapsd_rx_frame_threshold = __cpu_to_le32(10);
>>>
>>> Do the above lines assume all TDLS peers support TDLS buffer-sta
>>> (which is required for peer UAPSD)? Especially the value of
>>> tdls_puapsd_mask.
>
> No. The function you reffer to configures device itself not TDLS
> peers. Currently tdls peer uapsd buffer sta is not implemented as
> Michał wrote.

If the device configures UAPSD queues for itself, then it requires
buffer-sta support from its peer, not from itself.
But you've reassured me you don't require this from the peer, as it
would hurt ath10k vs. ath10k TDLS connections.

Arik