[PATCH] ath10k: fix htt t2h message conflicts among firmware revisions

[Michal Kazior]

On 19 March 2015 at 09:27, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Rajkumar Manoharan <rmanohar at qti.qualcomm.com> writes:
>
>> Target to host HTT messages are conflicting between 10.x and other
>> firmware revisions. By maintaining separate HTT T2H tables for each
>> firmware revisions (main, 10x and tlv) similar to WMI abstraction,
>> solves the conflicts.
>>
>> Cc: Michal Kazior <michal.kazior at tieto.com>
>> Signed-off-by: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
>
> So this is needed to get managements frames over HTT working, right?
> It's good to mention that in the commit log, does this look ok:
>
> Author: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
> Date:   Wed Mar 11 15:03:02 2015 +0530
>
>     ath10k: fix htt t2h message conflicts among firmware revisions
>
>     Target to host HTT messages are conflicting between 10.x and other
>     firmware revisions. By maintaining separate HTT T2H tables for each
>     firmware revisions (main, 10x and tlv) similar to WMI abstraction,
>     solves the conflicts.
>
>     This fix is needed to get management frames over HTT (ie.
>     ATH10K_FW_FEATURE_HAS_WMI_MGMT_TX disabled) working with 10.2.4.48-2 firmware.
>     Otherwise there will be unknown htt events and nothing works:
>
>     [30087.438343] ath10k_pci 0000:02:00.0: htt event (19) not handled
>     [30087.448691] ath10k_pci 0000:02:00.0: htt event (19) not handled
>     [30149.032974] ath10k_pci 0000:02:00.0: htt event (19) not handled
[...]
>
> When I was adding WMI_OP_VERSION, my idea was that we will add similar
> version for HTT as well once we need it. But I guess this is good enough
> for now, we can add HTT_OP_VERSION later if more changes are needed.

Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID
or something else?

It's not like HTT wasn't diverging. It was. However only WMI ABI was
seeing major breakage that needed taking care of. HTT changes were
small enough and could be ignored until now.

Perhaps the rename could be accompanied by FW API bump to 5?


Michał