[PATCH 2/3 RFC] ath10k: wmi: match wait_for_completion_timeout return type

Kalle Valo kvalo at qca.qualcomm.com
Fri Mar 13 09:20:01 PDT 2015


Nicholas Mc Guire <hofrat at osadl.org> writes:

> Return type of wait_for_completion_timeout is unsigned long not int.
> An appropriately named unsigned long is added and the assignments fixed up.
> Rather than returning 0 (timeout) or a more or less random remaining time
> (completion success) this return 0 or 1 which also resolves the type of the
> functions being int.
>
> Signed-off-by: Nicholas Mc Guire <hofrat at osadl.org>

Why does patch 2 in this patchset have RFC in the title but patches 1
and 3 not? That just makes me confused, I can't tell what you want me to
do with the patches. Normally I just drop all patches (or patchsets)
which have RFC, and that's what I'm going to do now.

To save everyone's time, when submitting something please state clearly
what's your intention.

-- 
Kalle Valo



More information about the ath10k mailing list