[PATCH] ath10k: Remove trace about getting temperature

Kalle Valo kvalo at qca.qualcomm.com
Tue Mar 10 08:54:55 PDT 2015


Matthias Kaehlcke <mka at chromium.org> writes:

> When ath10k debugging is enabled this trace generates a log entry
> every time the chip temperature is read. On systems polling the
> temperature this clutters the log with entries which aren't
> particularly useful. Remove this trace.
>
> Signed-off-by: Matthias Kaehlcke <mka at chromium.org>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index aeea1c7..1c86984 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -4881,7 +4881,6 @@ ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar)
>  	if (!skb)
>  		return ERR_PTR(-ENOMEM);
>  
> -	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
>  	return skb;

I'm worried that this is dangerous, as that means that not all WMI
commands will be in debug and something might be missed because of that.

Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or
adding a new log level?

-- 
Kalle Valo



More information about the ath10k mailing list