[PATCH 2/3] ath10k: always save/restore pci config space

Michal Kazior michal.kazior at tieto.com
Mon Mar 2 02:17:00 PST 2015


On 2 March 2015 at 10:25, Johannes Berg <johannes at sipsolutions.net> wrote:
> On Mon, 2015-03-02 at 10:23 +0100, Michal Kazior wrote:
>
>> > I believe the whole thing isn't necessary at all since the kernel's PCIe
>> > layer will take care of it.
>>
>> You mean only the pci_save_state() and pci_disable_device() or, the
>> resume counterpart as well? Hmm.
>
> Resume as well - but I believe it's all-or-nothing.
>
>> Earlier the resume counterpart didn't do any restore stuff and the
>> device ended up pretty confused..
>
> which may explain this.

Hmm.. I removed the save/restore/enable/disable completely and
re-tested. It seems to work fine as well.

I'll post a v2 later then. Thanks!


Michał



More information about the ath10k mailing list