[PATCH v2 2/7] ath10k: implement chanctx API

Michal Kazior michal.kazior at tieto.com
Fri Jan 30 05:47:27 PST 2015


On 30 January 2015 at 14:31, Johannes Berg <johannes at sipsolutions.net> wrote:
> On Fri, 2015-01-30 at 14:22 +0100, Michal Kazior wrote:
>
>> You'd probably have to add quite a few mutex_lock(iflist_mtx) around
>> drv_*() calls (not directly but somewhere at their call trees) to
>> guarantee driver can use lock-free iterate() version (which doesn't
>> exist yet). This could be tricky.
>
> Well, I was thinking you'd only use it in some places now - but it does
> seem a bit difficult to maintain.
>
> We've not typically had to worry about using the synchronous versions
> much since we mostly just need a single interface so we just pass it out
> and use it there, or so.

I'm not sure if you refer to iwlwifi or mac80211 now? If it's the
latter: even if you have an ops with, e.g. vif pointer, driver may
still need to iterate over interfaces in order to propagate some
side-effect changes or aggregate some values/recalculate.


Michał



More information about the ath10k mailing list