[PATCH v2 2/7] ath10k: implement chanctx API

Michal Kazior michal.kazior at tieto.com
Fri Jan 30 05:06:08 PST 2015


On 30 January 2015 at 13:58, Johannes Berg <johannes at sipsolutions.net> wrote:
>
>> +++ b/drivers/net/wireless/ath/ath10k/core.h
>
>> @@ -277,6 +282,7 @@ struct ath10k_vif {
>>       dma_addr_t beacon_paddr;
>>
>>       struct ath10k *ar;
>> +     struct ath10k_chanctx *arctx;
>
> you also have vif->chanctx_conf pointer, which you could use
>
> ultimately it's a software architecture decision - personally I wouldn't
> want to duplicate all that data and the lists etc. in the driver when
> mac80211 has them, but that's just my opinion. :)

I'm a bit reluctant to freely use mac80211 owned structures out of
mac80211_ops callback context, i.e. from a tasklet fearing
inconsistencies. Or am I worrying unnecessarily? If so I guess I'll
redo this and use mac80211's structures directly :-)


Michał



More information about the ath10k mailing list