Firmware debug messages stopped sometime after 3.18 (bisected)

[Ben Greear]

On 01/01/2015 05:17 PM, Ben Greear wrote:
> While trying to reproduce some bugs on ath10k in 3.19.0-rc2, I could not
> get any debuglog messages from the firmware.  For instance, in stock kernel
> it should print out something like this:
> 
>  wmi event debug mesg len 28
> 
> I got other wmi debug messages, so the debug level appeared correct.
> 
> The message shows up as expected in stock 3.18 kernel.
> 
> Was this done on purpose?
> 
> I've started a bisect...should track it down directly.

Took a while, but bisect points to this.  If you are doing bisect
yourself, or playing with changes near here, you must manually apply
the patch below to allow scan to work.  I'll try to figure out why
the patch below disables firmware debuglog messages next.  I assume
that was not the intention?

90174455ae058a1dcf1f3d344a9752385803c1d8 is the first bad commit
commit 90174455ae058a1dcf1f3d344a9752385803c1d8
Author: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
Date:   Fri Oct 3 08:02:33 2014 +0300

    ath10k: add support to configure pktlog filter

    Add support to configure packet log filters (tx, rx, rate control)
    via debugfs. To disable htt pktlog events set the filters to 0.

    ex:

    To enable pktlog for all filters

       echo 0x1f > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter

    To disable pktlog

       echo 0 > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter

    Signed-off-by: Rajkumar Manoharan <rmanohar at qti.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>

:040000 040000 1ff3b609db06d718fb22a7d8444a70e38a60ebcd 6504c0828edb532f19826167eab9ba0634b3f044 M	drivers


Patch to allow scan to work (this patch made it upstream a bit later):

[greearb at ben-dt2 linux-bisect]$ git diff
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index f65032f..d878fbe 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3506,10 +3506,10 @@ int ath10k_wmi_start_scan(struct ath10k *ar,
                return ret;

        if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
-               len = sizeof(struct wmi_start_scan_cmd) +
+               len = sizeof(struct wmi_10x_start_scan_cmd) +
                      ath10k_wmi_start_scan_tlvs_len(arg);
        else
-               len = sizeof(struct wmi_10x_start_scan_cmd) +
+               len = sizeof(struct wmi_start_scan_cmd) +
                      ath10k_wmi_start_scan_tlvs_len(arg);

        skb = ath10k_wmi_alloc_skb(ar, len);
[greearb at ben-dt2 linux-bisect]$


Thanks,
Ben

> 
> Thanks,
> Ben
> 


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com