[PATCH 1/3] ath10k: embed supported chip ids in hw_params

[Michal Kazior]

On 27 November 2014 at 08:30, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>
>> 2. Have a dedicatd pci-specific structure:
>>
>>  struct ath10k_pci_supported_chip {
>>    u16 dev_id;
>>    u32 chip_id;
>>  };
>>
>>  struct ath10k_pci_supported_chip ath10k_pci_supported_chips[] = {
>>    { QCA988X_2_0_DEVICE_ID, QCA988X_HW_2_0_CHIP_ID_REV },
>>    // ...
>>  };
>>
>> Probably the simplest and has least impact.
>
> Another idea which is a variation of this:
>
> In ath10k_core_register() we iterate through ath10k_hw_params_list and
> make sure that the chip id is supported and if not, bail out. If the
> chip id is found from the array continue the registration process like
> in this patch. Basically this would be a whitelist check.

This won't work because chip ids can overlap between different
hardware designs and you'd get false positives.


Michał